From 4546837e14273e4dd285cfb9576a602d816975ad Mon Sep 17 00:00:00 2001 From: Florian Haftmann Date: Tue, 28 Feb 2023 15:09:52 +0100 Subject: [PATCH] refactor: Prefer separate LABEL instructions LABELs can go to separate directives, which does not induce a penalty on the image since docker 1.10. See also https://dockerlabs.collabnix.com/beginners/dockerfile/Label_instruction.html Change-Id: Iac33480bc3f4069ab904279ad61b5c58746318c0 --- container/Dockerfile | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/container/Dockerfile b/container/Dockerfile index 8863c93..d51d72c 100644 --- a/container/Dockerfile +++ b/container/Dockerfile @@ -1,3 +1,4 @@ + FROM ubuntu:20.04 ARG GIT_BRANCH @@ -6,10 +7,10 @@ ARG GIT_CONSOLE_COMMIT ARG RELEASE_VERSION ARG SKYLINE_CONSOLE_PACKAGE_URL -LABEL skyline.build_branch=${GIT_BRANCH}\ - skyline.build_commit=${GIT_COMMIT} \ - skyline.build_console_commit=${GIT_CONSOLE_COMMIT} \ - skyline.release_version=${RELEASE_VERSION} +LABEL skyline.build_branch=${GIT_BRANCH} +LABEL skyline.build_commit=${GIT_COMMIT} +LABEL skyline.build_console_commit=${GIT_CONSOLE_COMMIT} +LABEL skyline.release_version=${RELEASE_VERSION} ENV LANG C.UTF-8 ENV LC_ALL C.UTF-8