baha/skyline-apiserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Fix server_name is null in volumes attachment

Browse Source 
Fix server_name is null in volumes attachment when volume
is attached to server(s).

Change-Id: I69132a2de6c1974e3c081b7cfff0f29b126837bc
This commit is contained in:
Boxiang Zhu 2022-08-26 13:42:32 +08:00
parent 3ccfeefb6c
commit 71473abbdc
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
skyline_apiserver/api/v1/extension.py
View File

@ -606,10 +606,6 @@ async def list_volumes(
if attachment["server_id"] not in server_ids: if attachment["server_id"] not in server_ids:
server_ids.append(attachment["server_id"]) server_ids.append(attachment["server_id"])
# Sometimes, the servers have been soft deleted, but the volumes will
# be still displayed on the volume page. If we do not get the recycle
# servers, the attachment server name for those volumes which are attached
# to these servers will be blank.
if all_projects: if all_projects:
tasks = [ tasks = [
keystone.list_projects( keystone.list_projects(
@ -621,10 +617,13 @@ async def list_volumes(
] ]
else: else:
tasks = [asyncio.sleep(0.01)] tasks = [asyncio.sleep(0.01)]
# We should split the server_ids with 100 number.
# If we do not do this, the length of url will be too long to do request. # Sometimes, the servers have been soft deleted, but the volumes will
# be still displayed on the volume page. If we do not get the recycle
# servers, the attachment server name for those volumes which are attached
# to these servers will be blank.
server_ids = list(set(server_ids)) server_ids = list(set(server_ids))
for i in range(0, len(server_ids), STEP): for server_id in server_ids:
tasks.extend( tasks.extend(
[ [
nova.list_servers( nova.list_servers(
@ -632,7 +631,7 @@ async def list_volumes(
session=current_session, session=current_session,
global_request_id=x_openstack_request_id, global_request_id=x_openstack_request_id,
search_opts={ search_opts={
"uuid": server_ids[i : i + STEP], "uuid": server_id,
"all_tenants": all_projects, "all_tenants": all_projects,
}, },
), ),
@ -641,7 +640,7 @@ async def list_volumes(
session=current_session, session=current_session,
global_request_id=x_openstack_request_id, global_request_id=x_openstack_request_id,
search_opts={ search_opts={
"uuid": server_ids[i : i + STEP], "uuid": server_id,
"status": "soft_deleted", "status": "soft_deleted",
"deleted": True, "deleted": True,
"all_tenants": all_projects, "all_tenants": all_projects,