From ebf89092fd19a7363d6c1190d836c133a669df06 Mon Sep 17 00:00:00 2001 From: chenliufeiyang Date: Fri, 20 Aug 2021 15:11:12 +0800 Subject: [PATCH] fix: Fix params' default value of function 1. Do not use mutable types as method parameter defaults Change-Id: Ie310114f53981451b50a366a0869be72bbfb4e01 --- .../skyline_apiserver/client/openstack/glance.py | 2 +- .../skyline_apiserver/client/openstack/keystone.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libs/skyline-apiserver/skyline_apiserver/client/openstack/glance.py b/libs/skyline-apiserver/skyline_apiserver/client/openstack/glance.py index 12be357..c438d59 100644 --- a/libs/skyline-apiserver/skyline_apiserver/client/openstack/glance.py +++ b/libs/skyline-apiserver/skyline_apiserver/client/openstack/glance.py @@ -28,7 +28,7 @@ from skyline_apiserver.client import utils async def list_images( profile: schemas.Profile, session: Session, - filters: Dict[str, Any] = {}, + filters: Dict[str, Any] = None, ) -> Any: try: kwargs = {} diff --git a/libs/skyline-apiserver/skyline_apiserver/client/openstack/keystone.py b/libs/skyline-apiserver/skyline_apiserver/client/openstack/keystone.py index c93a5c9..45bcb1c 100644 --- a/libs/skyline-apiserver/skyline_apiserver/client/openstack/keystone.py +++ b/libs/skyline-apiserver/skyline_apiserver/client/openstack/keystone.py @@ -29,9 +29,10 @@ async def list_projects( profile: schemas.Profile, all_projects: bool, session: Session, - search_opts: Dict[str, Any] = {}, + search_opts: Dict[str, Any] = None, ) -> Any: try: + search_opts = search_opts if search_opts else {} kc = await utils.keystone_client(session=session, region=profile.region) if not all_projects: search_opts["user"] = profile.user.id